mgrettondann/partridge-cpp
1
0
Fork 0
Code Issues 4 Pull Requests Activity

test: add independent placement validation #17

Merged
mcp merged 1 commits from codex/issue-1-tests into main 2026-07-30 16:41:11 +01:00
Conversation 0 Commits 1 Files Changed 5
+333 -1
mcp commented 2026-07-30 16:41:01 +01:00
Collaborator
Copy Link
Copy Source

Summary

  • add a CTest-backed deterministic correctness suite
  • independently validate dimensions, multiplicities, bounds, overlap, and complete coverage
  • validate known order-8 and constructed order-9 fixtures
  • cover small unsatisfiable solver inputs and prepare independent conversion of solver results
  • document Release, Debug, ASan, and UBSan test workflows

Testing

  • Release CTest: 3/3 passed
  • ASan CTest: 3/3 passed
  • UBSan CTest: 3/3 passed
  • Debug compilation intentionally continues to expose #7

Review

Independent review requested more useful diagnostics; placement indices, coordinates, sides, conflicting placements, and expected/actual multiplicities were added and verified. The feasible solver and order-1 runs remain deferred to #14 because they reproduce its completion overflow; the adapter required by that regression is included here.

Closes #1
Part of #16

## Summary - add a CTest-backed deterministic correctness suite - independently validate dimensions, multiplicities, bounds, overlap, and complete coverage - validate known order-8 and constructed order-9 fixtures - cover small unsatisfiable solver inputs and prepare independent conversion of solver results - document Release, Debug, ASan, and UBSan test workflows ## Testing - Release CTest: 3/3 passed - ASan CTest: 3/3 passed - UBSan CTest: 3/3 passed - Debug compilation intentionally continues to expose #7 ## Review Independent review requested more useful diagnostics; placement indices, coordinates, sides, conflicting placements, and expected/actual multiplicities were added and verified. The feasible solver and order-1 runs remain deferred to #14 because they reproduce its completion overflow; the adapter required by that regression is included here. Closes #1 Part of #16
mcp added 1 commit 2026-07-30 16:41:01 +01:00
test: add independent placement validation 0b65501c73 
Establish a CTest harness before changing solver behavior. Validate board dimensions, multiplicities, bounds, overlap and coverage against independent placement data, including known order-8 and constructed order-9 fixtures.

Document Debug and sanitizer workflows while keeping the defects tracked by #7 and #14 separate. Prepare a result adapter so the feasible solver regression can be enabled with the completion fix.

Tests: Release, ASan and UBSan CTest suites (3 passed each)

Refs: #1
mcp merged commit 0b65501c73 into main 2026-07-30 16:41:11 +01:00
mcp deleted branch codex/issue-1-tests 2026-07-30 16:41:11 +01:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No labels
Milestone
No items
No Milestone
Assignees
Clear assignees
mcp mgrettondann (Matthew Gretton-Dann)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: mgrettondann/partridge-cpp#17