bug: fix Results debug assertion #7

New Issue

2026-07-30T16:23:34+01:00

mcp commented

2026-07-30 16:23:34 +01:00

Background

Results::set() asserts against grid_[x + y * length_], but Results has no grid_ member. Release builds hide the expression through NDEBUG; Debug compilation fails.

The assertion should check the output string or otherwise express the intended invariant using members that exist.

Proposed work

Correct the assertion to inspect the rendered output buffer.
Review the intended duplicate-write invariant.
Add a Debug-build test that renders a valid solution.

Acceptance criteria

The project builds in Debug mode.
Rendering a valid solution passes assertions.
A deliberately conflicting render is covered if practical.
The fix is committed separately from performance work.

Reference

main.cc:82-87

## Background `Results::set()` asserts against `grid_[x + y * length_]`, but `Results` has no `grid_` member. Release builds hide the expression through `NDEBUG`; Debug compilation fails. The assertion should check the output string or otherwise express the intended invariant using members that exist. ## Proposed work - Correct the assertion to inspect the rendered output buffer. - Review the intended duplicate-write invariant. - Add a Debug-build test that renders a valid solution. ## Acceptance criteria - The project builds in Debug mode. - Rendering a valid solution passes assertions. - A deliberately conflicting render is covered if practical. - The fix is committed separately from performance work. ## Reference - `main.cc:82-87`

mcp referenced this issue

2026-07-30 16:25:50 +01:00

bench: add repeatable solver benchmark suite #8

mcp referenced this issue

2026-07-30 16:26:18 +01:00

roadmap: improve time to the first square solution #16

mgrettondann referenced this issue from a commit

2026-07-30 16:40:56 +01:00

test: add independent placement validation

mcp referenced this issue

2026-07-30 16:41:01 +01:00

test: add independent placement validation #17