mgrettondann/partridge-cpp
1
0
Fork 0
Code Issues 4 Pull Requests Activity

solver: replace cell DFS with skyline search #23

Merged
mcp merged 1 commits from codex/issue-4-skyline into main 2026-07-30 17:57:02 +01:00
Conversation 0 Commits 1 Files Changed 7
+296 -198
mcp commented 2026-07-30 17:55:47 +01:00
Collaborator
Copy Link
Copy Source

Summary

  • replace the board-area cell grid with a compact column skyline
  • branch on the deterministic smallest-width valley with exact undo
  • support ascending and descending candidates plus public/direct benchmarks
  • document completeness, complexity, measurements, and 10x10/11x11 test-tier decisions

Review

Independent diff review found no correctness issues. All completed benchmark solutions passed the independent validator. Direct order 10 exceeded a 20-second exploratory cap, so 10 and constructed 11 remain heavyweight benchmark cases rather than routine tests.

Testing

  • Release CTest: 10/10 passed
  • Debug CTest: 10/10 passed
  • AddressSanitizer CTest: 10/10 passed
  • UndefinedBehaviorSanitizer CTest: 10/10 passed
  • benchmark self-test passed
  • git diff --check passed

Closes #4

## Summary - replace the board-area cell grid with a compact column skyline - branch on the deterministic smallest-width valley with exact undo - support ascending and descending candidates plus public/direct benchmarks - document completeness, complexity, measurements, and 10x10/11x11 test-tier decisions ## Review Independent diff review found no correctness issues. All completed benchmark solutions passed the independent validator. Direct order 10 exceeded a 20-second exploratory cap, so 10 and constructed 11 remain heavyweight benchmark cases rather than routine tests. ## Testing - Release CTest: 10/10 passed - Debug CTest: 10/10 passed - AddressSanitizer CTest: 10/10 passed - UndefinedBehaviorSanitizer CTest: 10/10 passed - benchmark self-test passed - `git diff --check` passed Closes #4
mcp added 1 commit 2026-07-30 17:55:48 +01:00
solver: replace cell DFS with skyline search d751d1b13e 
Represent partial placements as column heights and branch on the narrowest local valley. This removes the board-area cell state and makes first-solution search substantially smaller for feasible orders.

Expose direct-search and candidate-order benchmark controls so the skyline core can be measured independently of odd-order construction. Document the completeness argument and the 10/11 test-tier decision.

Tests: Release, Debug, ASan, and UBSan CTest (10 passed each)

Refs: #4
mcp merged commit d751d1b13e into main 2026-07-30 17:57:02 +01:00
mcp deleted branch codex/issue-4-skyline 2026-07-30 17:57:02 +01:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No labels
Milestone
No items
No Milestone
Assignees
Clear assignees
mcp mgrettondann (Matthew Gretton-Dann)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: mgrettondann/partridge-cpp#23